Refactor CallbackConverter code #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now shorter and allows use of the ? operator inside callback code
4 tasks
kngwyu
approved these changes
Apr 9, 2020
|
Thank you for doing all this hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the portion of #797 which is related to
CallbackConverterchanges.It makes use of a
run_callbackfunction, which takes a closure to execute. The closure must return aPyResult.A change of this fashion was originally necessary for #797. However I think it's good independent of #797, because a lot of the code is easier to read after these changes (in my opinion). Many
matchstatements have been replaced with?as a result.I factored this out because I think #797 still might need more design before we can settle.